Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix data pivot initial settings #770

Merged
merged 3 commits into from
Jan 17, 2023
Merged

fix data pivot initial settings #770

merged 3 commits into from
Jan 17, 2023

Conversation

shapiromatron
Copy link
Owner

@shapiromatron shapiromatron commented Jan 15, 2023 •
edited
Loading

Fixed a bug where a user attempts to start with an initial data pivot template with an invalid settings.

This PR more defensively gets and updates settings, so that dictionary key errors aren't passed.

@munnsmunns munnsmunns requested review from caseyhans and removed request for munnsmunns January 17, 2023 20:59
caseyhans
caseyhans approved these changes Jan 17, 2023
View reviewed changes
Copy link
Collaborator

@caseyhans caseyhans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@shapiromatron shapiromatron merged commit d834d4e into main Jan 17, 2023
@shapiromatron shapiromatron deleted the dp-settings-error branch January 17, 2023 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caseyhans caseyhans caseyhans approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shapiromatron @caseyhans