Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Epi v2 metadata API endpoint #766

Merged
merged 9 commits into from
Jan 18, 2023
Merged

Epi v2 metadata API endpoint #766

merged 9 commits into from
Jan 18, 2023

Conversation

caseyhans
Copy link
Collaborator

@caseyhans caseyhans commented Jan 11, 2023

Adds a metadata API endpoint for epiv2, similar to the animal and epiv1 endpoints.

Example endpoints:

  • Animal (v1): /ani/api/metadata/ (not assessment specific)
  • Epi (v1): /epi/api/metadata/:id/ (assessment specific; requires read-access to assessment)
  • Epi (v2): /epidemiology/api/metadata/ (not assessment specific)

@shapiromatron shapiromatron changed the title EpiV2 metadata endpoint Epi v2 metadata API endpoint Jan 18, 2023
Copy link
Owner

@shapiromatron shapiromatron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

I added a few tests, and made the view look a little more like the animal metadata api view instead of the the epi v1. Therefore

  • No assessment metadata is shown, its global
  • No authentication is required

I made a few other changes along the way, but nothing really substantive. Nice job!

@shapiromatron shapiromatron merged commit 6fccb70 into main Jan 18, 2023
@shapiromatron shapiromatron deleted the epiv2-metadata-endpoint branch January 18, 2023 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants