Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show comparison set name for group on the result form #748

Merged
merged 2 commits into from
Dec 12, 2022

Conversation

shapiromatron
Copy link
Owner

Users reported difficulty in data entry for epi.Result groups for cases where there are multiple groups named the same thing across comparison sets. Therefore, we add the comparison set name in addition to the group name for the data entry label.

Old New
image image

@shapiromatron
Copy link
Owner Author

@munnsmunns please review when you have a minute; a good test might be http://127.0.0.1:8000/epi/result/100501471/update/

Copy link
Collaborator

@munnsmunns munnsmunns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Works as expected on the link you shared

@shapiromatron shapiromatron merged commit 919e70f into main Dec 12, 2022
@shapiromatron shapiromatron deleted the group-result-name branch December 12, 2022 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants