-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add ids to export #745
add ids to export #745
Conversation
@shapiromatron Let me know what you think of these changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it'd be better if we could keep the serializers as is, and then just insert the columns after they export had been created. There's a method here that I think gives all the data we need, on a reference queryset (which could be the ids from the study queryset:
models.Reference.objects.identifiers_dataframe(qs)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome job Matt. I had grand ideas to refactor what you did to make the study evaluations and invitro to use the same approach as the other exports, but once I started, I realized it would take a lot more work to complete. I would have done it exactly as you did.
The only change I made was moving the identifier data frame creation from the common app to the Study app, since its more a property of studies.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Andy! The changes look good
Added HERO, PubMed, and DOI values to risk of bias, animal, epi, epi meta, and in vitro exports.