Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ids to export #745

Merged
merged 19 commits into from
Jan 18, 2023
Merged

add ids to export #745

merged 19 commits into from
Jan 18, 2023

Conversation

shapiromatron
Copy link
Owner

@shapiromatron shapiromatron commented Dec 1, 2022

Added HERO, PubMed, and DOI values to risk of bias, animal, epi, epi meta, and in vitro exports.

@munnsmunns munnsmunns marked this pull request as ready for review January 6, 2023 17:01
@munnsmunns
Copy link
Collaborator

@shapiromatron Let me know what you think of these changes

Copy link
Owner Author

@shapiromatron shapiromatron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it'd be better if we could keep the serializers as is, and then just insert the columns after they export had been created. There's a method here that I think gives all the data we need, on a reference queryset (which could be the ids from the study queryset:

models.Reference.objects.identifiers_dataframe(qs)

Copy link
Owner Author

@shapiromatron shapiromatron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome job Matt. I had grand ideas to refactor what you did to make the study evaluations and invitro to use the same approach as the other exports, but once I started, I realized it would take a lot more work to complete. I would have done it exactly as you did.

The only change I made was moving the identifier data frame creation from the common app to the Study app, since its more a property of studies.

Copy link
Collaborator

@munnsmunns munnsmunns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Andy! The changes look good

@munnsmunns munnsmunns merged commit db335cd into main Jan 18, 2023
@munnsmunns munnsmunns deleted the add-identifiers-to-export branch January 18, 2023 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants