Enable deletion of resolved reference tags #741
Conversation
frontend/lit/TagReferences/Main.js
Outdated
| }> | ||
| {this.state.showFullTag | ||
| ? tag.get_full_name() | ||
| : tag.data.name} | ||
| </span> | ||
| ))} | ||
| {selectedReferenceUserTags |
There was a problem hiding this comment.
this is also too complicated; can we generate the list of items as just JS code as a variable above in the render method, not within the JSX component
There was a problem hiding this comment.
This has been simplified after other refactors; since its just a single line filter now I don't think it would make much sense to define it in the render method
hawc/static/css/hawc.css
Outdated
| border: 0.15rem dotted #ffffff; | ||
| color: maroon; | ||
| background-color: #ffffff; | ||
| border: 0.15rem dotted maroon; |
There was a problem hiding this comment.
add some transparency too?
There was a problem hiding this comment.
I changed the transparency to 0.5, which I think helps make it more readable:
Anything less though and the strikethrough doesn't come across very well.
|
The conflict resolution page has also been updated to display tags in the same manner as the tagging view:
|
|
@shapiromatron I did some refactoring outside of your recommendations, which outdates one of your comments; let me know if you like these refactors as a whole and if you're fine with the compromise on your one comment. |
|
Changes look good! |
This is an example of how we can handle deleting resolved tags when conflict resolution is enabled.
When user tags don't exist for a reference, the resolved tags are added by default:
From here, a user can add additional tags and also remove resolved tags:
If a resolved tag is removed, it is still displayed with a strikethrough. Clicking on it again will reapply it.