User tag screening #735
Merged
User tag screening #735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # hawc/apps/lit/serializers.py # hawc/apps/lit/views.py # hawc/static/css/hawc.css
shapiromatron
approved these changes
Nov 17, 2022
There was a problem hiding this comment.
LGTM - I changed how we fetch user tags. switching to use ArrayAgg, but in the future when we update to django 4, using ArraySubquery might be a better way to go. I suspect we can do lots of other QS optimizations with that's available.
| @@ -155,6 +155,7 @@ class Reference extends Component { | |||
| {data.abstract ? ( | |||
| <div | |||
| className="abstracts resize-y p-2" | |||
| style={data.abstract.length > 1500 ? {height: "45vh"} : null} | |||
There was a problem hiding this comment.
that's nice - so it only sets a bound if it's a long abstract?
There was a problem hiding this comment.
yeah that way longer abstracts aren't overwhelming on page load, but users can still expand to show the full abstract if they wish. and there's no weird oversized box with shorter abstracts
| @@ -351,6 +352,18 @@ def prune_tags(self, root_tag, pruned_tags, descendants: bool = False): | |||
| ) | |||
| return self.exclude(query).distinct("pk") | |||
|
|
|||
| def user_tags(self, user_id: int) -> dict[int, list[int]]: | |||
There was a problem hiding this comment.
I changed how we're building this dictionary for the serializer since it looked like the old way required a query for each reference if user references were found
| @@ -107,7 +107,7 @@ <h3>Manually added references</h3> | |||
|
|
|||
| window.app.startup("litStartup", function(lit){ | |||
| let tagtree = new lit.TagTree(config.tags[0], config.assessment_id, null); | |||
| tagtree.render(document.getElementById('tags')) | |||
| tagtree.render(document.getElementById('tags'), {handleTagClick: (x) => {window.location.href = x.get_list_link()}}) | |||
| @@ -286,14 +286,19 @@ def get_context_data(self, **kwargs): | |||
| return context | |||
|
|
|||
| def get_app_config(self, context) -> WebappConfig: | |||
| references = [ref.to_dict() for ref in context["object_list"]] | |||
There was a problem hiding this comment.
... and we add to the dictionaries here instead of in the to_dict() view
shapiromatron
added a commit
that referenced
this pull request
Nov 22, 2022
* Literature Conflict Resolution Database Models (#708) * database models * reorder * updates to database models * reorganize views * update form url * update admin * fix user reference tags * fix tests * fix integration test * no message * fix broken build Co-authored-by: Andy Shapiro <shapiromatron@gmail.com> * Create UserReferenceTag objects (#716) * Save user reference tag object when tags are changed * revert unused changes * add conflict resolution case in update_tags * add assessment for testing conflict resolution * fix tests * remove unused import * add test * add prefetch * lint * Add resolved field to user tags and has_conflict property to refs * updates from review * tune database * restore all API actions * change argument order Co-authored-by: Andy Shapiro <shapiromatron@gmail.com> * Reorganize Screening Page Layout (#714) * redo screening page layout * move remove all tags btn * updates * integration test * updates * use mobx for slideAway * show full tag toggle * prop validation * add screening instructions * instructions updates * style changes * keyword highlighting * lint * undo style change addressed in #726 * fix for no references * updates * fix padding for prime flavor * random updates * fix linting * use LocalStorage class to handle these * apply highlighting to title * pull out of class to make function * rename to string instead of int-looking string * fix n+1 query issue * fix common edge case where there are no keywords Co-authored-by: Andy Shapiro <shapiromatron@gmail.com> * Stub new lit views (#721) * stub new lit views * format * minor updates Co-authored-by: Andy Shapiro <shapiromatron@gmail.com> * hover tag animation (#731) * change tag hover style * minor animation and padding tweaks * change to gray * frontend lint fix? * tests fix > * update github-actions (#730) * update backend * update action versions * try using built-in postgres * add debugging * fix statement * add settings * fix? run on main/next branch anytime * cleanup/standardize * fix yarn cache dir * Tagging filters (#736) * Make universal tagging view w/ filter form * Combine tagging views * Removed v2 from current implementation * Removed path for deleted view * Formatted js files * Fix tests * Fix query parameters * Updated reference search page with changes to reference filterset * improve queryset performance; reorder form * fix css when abstracts are short * use args instead of kwargs for simple reverse statements Co-authored-by: Andy Shapiro <shapiromatron@gmail.com> * User tag screening (#735) * Make universal tagging view w/ filter form * add user tag distinction to screening view * lint * Combine tagging views * Removed v2 from current implementation * Removed path for deleted view * Formatted js files * Fix tests * Fix query parameters * Updated reference search page with changes to reference filterset * style and test fix * updates * improve queryset performance; reorder form * fix css when abstracts are short * use args instead of kwargs for simple reverse statements * remove prefetch Co-authored-by: Daniel Rabstejnek <rabstejnek@gmail.com> Co-authored-by: Andy Shapiro <shapiromatron@gmail.com> * literature tag conflict resolution view (#734) * Add view/template from wf * make conflict resolution view display tag conflicts correctly * remove tags diff highlighting for fewer queries * add api endpoint for and hx-post for resolving conflict * wip fix resolve_user_tag_conflicts method * add form tag and hx-target * create reference conflict template * refine view and css * add template rendering to api endpoint * add reference tags to view (if they exist) * remove unnecessary method * change tag style * add tag diffs * fix view inheritance * remove column for frontend filter * add distinct to queryset * style updates * Added filter form to conflict resolution view, added filter for choosing tag types to filter against, updated other filter forms with new filter * updates * remove queryset additions * cleanup css * update css * updates from final review * lint Co-authored-by: casey1173 <caseyhansen1999@gmail.com> Co-authored-by: Daniel Rabstejnek <rabstejnek@gmail.com> Co-authored-by: Andy Shapiro <shapiromatron@gmail.com> * Reference List Overflow (#738) * Add view/template from wf * make conflict resolution view display tag conflicts correctly * remove tags diff highlighting for fewer queries * add api endpoint for and hx-post for resolving conflict * wip fix resolve_user_tag_conflicts method * add form tag and hx-target * create reference conflict template * refine view and css * add template rendering to api endpoint * add reference tags to view (if they exist) * remove unnecessary method * change tag style * add tag diffs * fix view inheritance * remove column for frontend filter * add distinct to queryset * style updates * fix for reference overflow * revert merge diffs * remove height * take 2? * fix edge case with tags Co-authored-by: munnsmunns <mmunns16@gmail.com> Co-authored-by: Andy Shapiro <shapiromatron@gmail.com> Co-authored-by: Casey Hansen <42587248+casey1173@users.noreply.github.com> Co-authored-by: Matt Munns <mmunns16@gmail.com> Co-authored-by: Daniel Rabstejnek <rabstejnek@gmail.com> Co-authored-by: casey1173 <caseyhansen1999@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds user tag distinction to screening view
TODO: