Use regex for test that involves a content type ID #725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
If you change the CT in api-visual-barchart.json and api-visual-rob-heatmap.json, as will happen in the future, this will fail, is that correct?
I think we need to update the things that compare the JSON for this and the others in the screenshot to replace obj_ct=\d+ with obj_ct=9999 on the write to disk as well. That way when the obj_ct changes the ct will always be the same...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces a hard coded value for content type ID in a test with a regex to make that test more resilient.
Prior to this, whenever new django models are added, the content-type IDs may change, which can break tests.