Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed OrderedDict #722

Merged
merged 3 commits into from
Nov 9, 2022
Merged

Removed OrderedDict #722

merged 3 commits into from
Nov 9, 2022

Conversation

rabstejnek
Copy link
Collaborator

@rabstejnek rabstejnek commented Nov 7, 2022 •
edited by shapiromatron
Loading

Native dictionaries were guaranteed to preserve order in python 3.6, and this was introduced as part of the language specification in python 3.7. Therefore, remove OrderedDict.

@shapiromatron shapiromatron marked this pull request as ready for review November 8, 2022 11:53
shapiromatron
shapiromatron approved these changes Nov 9, 2022
View reviewed changes
Copy link
Owner

@shapiromatron shapiromatron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

strange code around old patterns, glad this is gone!

@shapiromatron shapiromatron merged commit c4a680b into main Nov 9, 2022
@shapiromatron shapiromatron deleted the remove-ordereddict branch November 9, 2022 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shapiromatron shapiromatron shapiromatron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rabstejnek @shapiromatron