Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace reference and study filters with django-filter filtersets #719

Merged
merged 32 commits into from
Nov 14, 2022

Conversation

rabstejnek
Copy link
Collaborator

@rabstejnek rabstejnek commented Oct 27, 2022

Swapped in django-filter on the following pages:

  • /study/assessment/<pk>/
  • /lit/assessment/<pk>/references/search/
  • /rob/assessment/<pk>/study-assignments/
  • /rob/assessment/<pk>/study-assignments/updates/

@rabstejnek rabstejnek changed the base branch from main to prefilters October 27, 2022 19:31
@rabstejnek rabstejnek changed the title WIP: Replace reference and study filters with django-filter filtersets Replace reference and study filters with django-filter filtersets Oct 31, 2022
…ields, form layout, etc. Added title/abstract filter to reference filterset
Base automatically changed from prefilters to main November 9, 2022 16:46
@rabstejnek rabstejnek marked this pull request as draft November 9, 2022 19:31
@shapiromatron
Copy link
Owner

@rabstejnek is this one ready? it looks like it is from the merge status and tests passing, but wanted to see b/c it's still in draft

@rabstejnek rabstejnek marked this pull request as ready for review November 10, 2022 19:04
@rabstejnek
Copy link
Collaborator Author

@rabstejnek is this one ready? it looks like it is from the merge status and tests passing, but wanted to see b/c it's still in draft

Yep, its ready for review!

Copy link
Owner

@shapiromatron shapiromatron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Ok to merge if you're happy w/ my changes.

@rabstejnek rabstejnek merged commit 58aaac1 into main Nov 14, 2022
@rabstejnek rabstejnek deleted the other-prefilters branch November 14, 2022 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants