Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SVG rasterization fixes #712

Merged
merged 1 commit into from
Oct 24, 2022
Merged

SVG rasterization fixes #712

merged 1 commit into from
Oct 24, 2022

Conversation

shapiromatron
Copy link
Owner

@shapiromatron shapiromatron commented Oct 20, 2022 •
edited
Loading

Add JPEG export format for downloading large visuals where compression is needed:

image

Fixed two additional issues:

  1. Fixed cases where the rasterized image was scaling incorrectly (use getBoundingClientRect)
  2. Fixed cases where extremely large canvas (>32k pixel height/width) cannot be exported because of browser limits

munnsmunns
munnsmunns approved these changes Oct 21, 2022
View reviewed changes
Copy link
Collaborator

@munnsmunns munnsmunns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@shapiromatron shapiromatron merged commit 0ad676d into main Oct 24, 2022
@shapiromatron shapiromatron deleted the svg-rendering branch October 24, 2022 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@munnsmunns munnsmunns munnsmunns approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shapiromatron @munnsmunns