-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add BMDS v3.3 to database and make prior versions read only #711
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, a few more changes
9c2848e
to
96ed544
Compare
@@ -10,6 +10,9 @@ const startup = (name, cb) => { | |||
case "bmds2Startup": | |||
import("./bmd/bmds2/index.js").then(app => cb(app.default)); | |||
break; | |||
case "bmds3Startup": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice job with this; figuring this out is tricky...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Adds the framework for implementing BMDS v3.3 in HAWC.