Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BMDS v3.3 to database and make prior versions read only #711

Merged
merged 13 commits into from
Oct 27, 2022

Conversation

munnsmunns
Copy link
Collaborator

@munnsmunns munnsmunns commented Oct 20, 2022

Adds the framework for implementing BMDS v3.3 in HAWC.

  • Existing BMD Sessions are now read-only, and any existing assessments without a BMD session are set to the newest version of BMDS.
  • Adds a "Hello World" placeholder for BMDS 3 implementation in HAWC.

@munnsmunns munnsmunns changed the base branch from main to next October 24, 2022 19:50
@shapiromatron shapiromatron marked this pull request as ready for review October 24, 2022 22:51
Copy link
Owner

@shapiromatron shapiromatron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, a few more changes

@shapiromatron shapiromatron changed the base branch from next to main October 27, 2022 02:22
@@ -10,6 +10,9 @@ const startup = (name, cb) => {
case "bmds2Startup":
import("./bmd/bmds2/index.js").then(app => cb(app.default));
break;
case "bmds3Startup":
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice job with this; figuring this out is tricky...

@shapiromatron shapiromatron changed the title Add BMDS v3.3 Add BMDS v3.3 to database and make prior versions read only Oct 27, 2022
Copy link
Owner

@shapiromatron shapiromatron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shapiromatron shapiromatron merged commit 5b46f73 into main Oct 27, 2022
@shapiromatron shapiromatron deleted the bmds330 branch October 27, 2022 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants