Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HERO error catching; RIS flag enabled #705

Merged
merged 7 commits into from
Oct 27, 2022
Merged

Conversation

munnsmunns
Copy link
Collaborator

@munnsmunns munnsmunns commented Oct 17, 2022

  • Handle 500 errors from HERO requests. Previously, if HERO returned out error, HAWC would also throw an error. Now we properly handle and report to the user an issue.
  • Add feature flag to hide RIS import button. RIS files are not recommend when possible as we lose a lot of control on data quality when using; we can disable in some deployment environments. Users can still import an RIS if they really want to, but they'd have to navigate directly to the URL. To disable:
export HAWC_FEATURE_FLAGS='{"ALLOW_RIS_IMPORTS":false}'

@munnsmunns munnsmunns marked this pull request as ready for review October 18, 2022 13:28
Copy link
Owner

@shapiromatron shapiromatron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@shapiromatron shapiromatron changed the title Import improvements HERO error catching; RIS flag enabled Oct 25, 2022
@shapiromatron shapiromatron merged commit 044619b into main Oct 27, 2022
@shapiromatron shapiromatron deleted the hero-import-errors branch October 27, 2022 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants