Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

500-errors #696

Merged
merged 20 commits into from
Sep 12, 2022
Merged

500-errors #696

merged 20 commits into from
Sep 12, 2022

Conversation

munnsmunns
Copy link
Collaborator

@munnsmunns munnsmunns commented Sep 6, 2022 •
edited
Loading

Fixes several 500 errors discovered in the latest deployment of HAWC:

  • Fix 500 error when clicking 'cancel' after uploading an excel for excel to json conversion.
  • Fix 500 errors related to animal groups with no dosing regime. Also adds can_delete logic to prevent accidentally deleting a dosing regime that is associated with another animal group.

@shapiromatron shapiromatron marked this pull request as ready for review September 11, 2022 00:29
shapiromatron
shapiromatron requested changes Sep 12, 2022
View reviewed changes
Copy link
Owner

@shapiromatron shapiromatron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more test and a quick review of my changes. Please update the description as well

@shapiromatron shapiromatron merged commit 7c610a5 into next Sep 12, 2022
@shapiromatron shapiromatron deleted the 500-errors branch September 12, 2022 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shapiromatron shapiromatron shapiromatron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@munnsmunns @shapiromatron