Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

import default legend location position for rob heatmaps and barcharts #685

Merged
merged 7 commits into from
Aug 30, 2022

Conversation

shapiromatron
Copy link
Owner

@shapiromatron shapiromatron commented Aug 22, 2022

Instead of placing legends awkwardly at bottom of figure, try to calculate a default position to the right of the heatmap or barchart:

Heatmap:
image

Barchart:
image

@shapiromatron shapiromatron marked this pull request as ready for review August 22, 2022 04:18
@shapiromatron shapiromatron marked this pull request as draft August 22, 2022 04:22
@shapiromatron shapiromatron removed the request for review from munnsmunns August 22, 2022 04:22
@shapiromatron shapiromatron marked this pull request as ready for review August 24, 2022 00:42
@shapiromatron shapiromatron changed the title add default legend location position for rob heatmaps and barcharts import default legend location position for rob heatmaps and barcharts Aug 24, 2022
@shapiromatron shapiromatron changed the base branch from main to next August 30, 2022 19:03
Copy link
Owner Author

@shapiromatron shapiromatron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job; one change I made was to update the migrations to use bulk_update; originally this wasn't available but this is more performant

@shapiromatron shapiromatron merged commit dd052a1 into next Aug 30, 2022
@shapiromatron shapiromatron deleted the default-rob-legend branch August 30, 2022 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants