-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Search delete warnings #662
Conversation
@casey1173 ready for review. I made two big changes:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed some wording slightly for personal clarity--feel free to change back if you'd like.
I also changed the comma-separated list to a semicolon-separated list since most studies have commas in the name (e.g., Butterworth, 1998, 1023693).
Add more guards to prevent cascading delete of reference imports
Make it very clear when a user is about to remove a search that has data related to it. Instead of a hypothetical warning, show exact numbers for data removed from this deletion.
Before:

After:

In addition, add guard on PubMed imports to also not delete removed references which have related studies.