Django field for Quill input #655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into quill-widget
… validation, added tests
|
@shapiromatron I added two more commits that I believe are helpful, but can be safely reverted if you disagree.
|
…dget # Conflicts: # hawc/apps/lit/templates/lit/search_copy_selector.html # hawc/apps/riskofbias/forms.py
shapiromatron
approved these changes
Sep 1, 2022
| @@ -95,6 +92,9 @@ def helper(self): | |||
|
|
|||
|
|
|||
| class ImportForm(SearchForm): | |||
| class Meta(SearchForm.Meta): | |||
| @@ -107,6 +107,9 @@ | |||
| <script type="text/javascript" src="{% static 'vendor/jqueryui/1.10.3/jquery-ui.min.js' %}"></script> | |||
| <script type="text/javascript" src="{% static 'vendor/htmx/1.6.1/htmx.min.js' %}"></script> | |||
| {% render_bundle 'main' %} | |||
| {% if form %} | |||
There was a problem hiding this comment.
this is very nice. we do have to watch out to make sure that we still need to add form.media on any htmx stuff, but that makes sense conceptually so i like this pattern
| @@ -98,4 +99,7 @@ export default function() { | |||
| q.stc.enableModals(); | |||
| } | |||
| }); | |||
|
|
|||
| // restore original focus | |||
| $(focusedItem).focus(); | |||
There was a problem hiding this comment.
fyi; I added this, now I think quill doesn't mess with which form field is focused on anymore
| ".who.int", | ||
| "sciencedirect.com", | ||
| "doi.org", |
There was a problem hiding this comment.
also added doi.org as a valid URL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
QuillField / QuillWidget
Added a new
QuillFieldfield andQuillWidgetwidget for use in Django forms. This removes the need to manually quillify anytextareas where we want HTML content, and allows for a centralized place to clean and validate incoming HTML data.Cleaning/validating
Cleaning is now performed on passed in HTML to resolve any rendering issues and to make sure any content doesn't look out of place within the app.
Validation is done on links, since this is something that can't be handled automatically through cleaning; if a link is given that doesn't fall within our constraints, then a validation error is given:
Notes:
Bugs: