Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

epi v2 finalization #642

Merged
merged 45 commits into from
Jul 26, 2022
Merged

epi v2 finalization #642

merged 45 commits into from
Jul 26, 2022

Conversation

munnsmunns
Copy link
Collaborator

@munnsmunns munnsmunns commented Jul 8, 2022

Implements requested changes from the most recent Epi group feedback

  • Change "Create" button to "Add Row"
  • Add Hair to biomonitoring choices
  • Add "Units" field to Data extraction
  • Make Source, Age category, Exposure measurement types required
  • Make Sex, Type of variance estimate (assuming variance is not filled out), Lower/upper interval type (assuming lower/upper interval is not filled out), Lower/upper bound type (assuming lower/upper bound is not filled out) not required
  • double length of AdjustmentFactor description field
  • Add a symbols dropdown to forms for easy copy/pasting of greek symbols, super/subscripts, etc.
  • Re-order Outcome fields and rename to System, Effect, Effect detail, and Endpoint/outcome
  • Central tendency displays median or mean if available, does not show range in the table view

Remove the feature flag, clean up migrations, and release!

@munnsmunns munnsmunns marked this pull request as ready for review July 18, 2022 16:36
@munnsmunns munnsmunns requested a review from shapiromatron July 18, 2022 16:36
@shapiromatron shapiromatron changed the title Epi v2 tweaks Epi v2 refinements Jul 18, 2022
Copy link
Owner

@shapiromatron shapiromatron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this will be our release, can we also tear out the "coming soon" stuff that we previously had:

  1. Remove the ENABLE_EPI_V2 feature flag
  2. Update the Study detail page to allow for epi v2 extractions

@shapiromatron shapiromatron changed the title Epi v2 refinements epi v2 finalization Jul 26, 2022
Copy link
Owner

@shapiromatron shapiromatron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job @munnsmunns and @casey1173! Excited to release this!

@@ -1 +1,2 @@
NO_LABEL = "---"
NONE = "N/A"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed the variable to NA instead of NONE, since those are two separate things

</div>
</span>
<script>
$('.dropdown-menu').click(function (e) {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will stop propagation of all dropdown-menus on the page; I made it more narrow

@@ -0,0 +1,21 @@
<span name="formLegendPulldown">
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed this span; it's not used anywhere. Also a span is an inline container, but a div is a block; which generally you'd only nest within other block elements, I think. My html5 knowledge is not great, but I think that's generally correct...

@shapiromatron shapiromatron merged commit 2ea659a into main Jul 26, 2022
@shapiromatron shapiromatron deleted the epi-v2-tweaks branch July 26, 2022 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants