-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
epi v2 finalization #642
epi v2 finalization #642
Conversation
…into epi-v2-tweaks
…into epi-v2-tweaks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this will be our release, can we also tear out the "coming soon" stuff that we previously had:
- Remove the ENABLE_EPI_V2 feature flag
- Update the
Study detail
page to allow for epi v2 extractions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job @munnsmunns and @casey1173! Excited to release this!
hawc/apps/common/constants.py
Outdated
@@ -1 +1,2 @@ | |||
NO_LABEL = "---" | |||
NONE = "N/A" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changed the variable to NA instead of NONE, since those are two separate things
</div> | ||
</span> | ||
<script> | ||
$('.dropdown-menu').click(function (e) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this will stop propagation of all dropdown-menus on the page; I made it more narrow
@@ -0,0 +1,21 @@ | |||
<span name="formLegendPulldown"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed this span; it's not used anywhere. Also a span is an inline container, but a div is a block; which generally you'd only nest within other block elements, I think. My html5 knowledge is not great, but I think that's generally correct...
Implements requested changes from the most recent Epi group feedback
Remove the feature flag, clean up migrations, and release!