Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tagtree - show references on root node #1144

Merged
merged 2 commits into from
Dec 6, 2024
Merged

tagtree - show references on root node #1144

merged 2 commits into from
Dec 6, 2024

Conversation

shapiromatron
Copy link
Owner

@shapiromatron shapiromatron commented Dec 3, 2024 •
edited
Loading

Previously we didn't show references on the root node, now that we added pagination #426, show on the root node as well.

URLS to check:

  • /lit/assessment/:assessment-id/references/visualization/
  • /summary/visual/assessment/:assessment-id/:visual-id/ (custom tagtree visual)

rabstejnek
rabstejnek approved these changes Dec 6, 2024
View reviewed changes
Copy link
Collaborator

@rabstejnek rabstejnek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good change, especially with the custom visuals maybe having a root that users would be interested in inspecting. Tested it out with no problem!

@shapiromatron shapiromatron merged commit 4fe463f into main Dec 6, 2024
6 checks passed
@shapiromatron shapiromatron deleted the root-node-tags branch December 6, 2024 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rabstejnek rabstejnek rabstejnek approved these changes

Assignees

@shapiromatron shapiromatron

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shapiromatron @rabstejnek