Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix overwhelming copy as new selectors #1138

Merged
merged 2 commits into from
Dec 6, 2024
Merged

fix overwhelming copy as new selectors #1138

merged 2 commits into from
Dec 6, 2024

Conversation

shapiromatron
Copy link
Owner

@shapiromatron shapiromatron commented Nov 21, 2024

Add autocomplete to the visual copy as new selectors:

  • /summary/data-pivot/assessment/:id/create/copy-as-new-selector/
  • /summary/assessment/:id/visuals/2/copy/

I did make some css changes to single select2 inputs, I'm not sure if there were possible side effects.

/summary/data-pivot/assessment/:id/create/copy-as-new-selector/
/summary/assessment/:id/visuals/2/copy/
Copy link
Collaborator

@caseyhans caseyhans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, works well. The css changes don't seem to cause issues to other single select2 widgets. LGTM!

@caseyhans caseyhans removed their assignment Dec 4, 2024
@shapiromatron shapiromatron merged commit 0b9f204 into main Dec 6, 2024
6 checks passed
@shapiromatron shapiromatron deleted the copy-as-new branch December 6, 2024 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants