Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icf cpheapm70 deep clone study, study evaluation, bioassay, epiv2 #1117

Open
wants to merge 26 commits into
base: main
Choose a base branch
from

Conversation

BerkowitzMaxICF
Copy link
Collaborator

@BerkowitzMaxICF BerkowitzMaxICF commented Oct 9, 2024

Add the ability for a user to clone a study, including study evaluation and animal bioassay information, from one assessment to another assessment. This will do a deep clone that copies all related information.

The new page is listed under the Study List page:
image

You select the source assessment to copy from, and then which studies to clone. If study evaluation is selected, you must also map metrics from the from destination to source:
image

Copy link
Owner

@shapiromatron shapiromatron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good so far, I added a few comments...

@BerkowitzMaxICF BerkowitzMaxICF marked this pull request as ready for review October 31, 2024 15:02
@shapiromatron shapiromatron self-assigned this Nov 4, 2024
@shapiromatron shapiromatron changed the title Icf cpheapm70 integrate deep clone Icf cpheapm70 deep clone study, study evaluation, bioassay Feb 18, 2025
@shapiromatron shapiromatron changed the title Icf cpheapm70 deep clone study, study evaluation, bioassay Icf cpheapm70 deep clone study, study evaluation, bioassay, epiv2 Feb 18, 2025
Copy link
Owner

@shapiromatron shapiromatron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great start! I made a number of changes to address lots of edge cases, and hopefully improved error messaging to users when things didn't behave as expected. The initial work was a good template for reworking.

@shapiromatron
Copy link
Owner

Adding @rabstejnek to the review; I made so many changes I think it needs another set of eyes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants