Bulk tagging JS fix #1115
Merged
Bulk tagging JS fix #1115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shapiromatron
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the IDs in an excel file were parsed as strings, then the bulk tagging form would not be able to map them to integer based IDs. This PR addresses this issue by casting all incoming excel IDs explicitly as strings and the keys in the reference map also as strings; since these "stringified" values are only used for matching and because some IDs (ie doi) are already strings this seemed like the most unified approach.
Whitespace is also trimmed from incoming excel IDs, since identifiers stored in HAWC should not have leading or trailing whitespace; this also aids in a better match between excel IDs and the reference map.