Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add exports to Prisma Config form #1097

Merged
merged 10 commits into from
Sep 9, 2024
Merged

Conversation

munnsmunns
Copy link
Collaborator

@munnsmunns munnsmunns commented Sep 5, 2024

Update config form to use exported data of tags and searches.
image

@munnsmunns munnsmunns marked this pull request as ready for review September 6, 2024 21:26
Copy link
Owner

@shapiromatron shapiromatron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to fix an error in your logic where the Object.assign never actually included the tags. Made a few other edits too

  • 75e577d fix section vs box (3 minutes ago) {Andy Shapiro}
  • fc89065 add default null links (3 minutes ago) {Andy Shapiro}
  • d246366 fix filter options to include both tags and searches (3 minutes ago) {Andy Shapiro}

const search_options = this.count_data.searches.map(search => {
return {id: "search_" + search.id, label: "IMPORT | " + search.title};
});
const options = Object.assign([], tag_options, search_options);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this doesn't work as currently implemented; I changed to this:

_.flatten([{id: NULL_VALUE, label: NULL_VALUE}, tag_options, search_options])

@shapiromatron shapiromatron merged commit 505a8d1 into main Sep 9, 2024
6 checks passed
@shapiromatron shapiromatron deleted the exports-in-prisma-config branch September 9, 2024 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants