add a user agent for external requests #1096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
munnsmunns
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a
User-Agentfor all external http requests. This makes it easier for 3rd party tools to identify our software; the user agent can be configured by changing theHAWC_USER_AGENTenvironment variable.In addition, standardize how we make external requests using a custom request session.
Finally, refactor the ancient
pubmed.pyfile slightly to make the logic a little bit easier to follow. It's still messy, but we get the pubmed API key directly from the django config settings instead of an old singleton pattern (I think I just learned about that design pattern in school when I wrote this 🤣 ).I regenerated all the VCR cassettes to confirm that everything did still work as expected.