Make AssessmentValue.study M2M #1093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
munnsmunns
commented
Sep 10, 2024
rabstejnek
reviewed
Sep 13, 2024
There was a problem hiding this comment.
Looks good! I just had one comment about merging the migrations introduced in this PR.
Also, I noticed a comment that was marked as resolved regarding some of our m2m helper methods. While we normally pass them a field string, we can also pass them expressions, so we may be able to build each type of identifier (ie pmids, hero ids, etc) if we use a subquery. Just food for thought if we plan on implementing it.
hawc/apps/assessment/migrations/0041_assessmentvalue_studies_and_more.py
Outdated
Show resolved
Hide resolved
shapiromatron
approved these changes
Sep 19, 2024
There was a problem hiding this comment.
Looks good. There were larger two changes I had to fix during testing
- The study autocomplete showed ALL studies across all assessments, not just those for one particular assessment.
- The migration failed if a study is None and and it was trying to write a null study in the studies many to many relation
Diffs are here:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
studyforeign key field to be a many-to-many relationship instead. Also modifies the help text forvalueandpod_valueto make it clearer that entering scientific notation is valid.