Labeled Items List #1091
Merged
Labeled Items List #1091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
caseyhans
commented
Sep 1, 2024
•
rabstejnek
reviewed
Sep 13, 2024
caseyhans
added a commit
that referenced
this pull request
Sep 27, 2024
* Assessment tag schema & crud * Updates * Linting * Linting on html * Dirty updates to tag application on detail views * Update actions js * Fixed tag creation bugginess * Linting * Add tagging to summary tables * Added htmx tag indicators * Stub in htmx tag indicators for react visuals * improve tag_indicators * add text_color field, update migration * format * update tests * update tag/label creation page * Added tags to visual filterset * Added tag indicators to other react visuals * add labels to lists for visuals * linting * js lint * change 'tag' to 'label' across UI * fix visual list clip path bug * update dynamic_fields * add list labels for datapivots & summary tables * add label nesting on create page * fix tests * merge templates, add htmx scroll animations * change default tag color to epa primary * readd visual captions to list without overflowing * Added tag filter to summary table filterset * Update permissions * Add view permissions for published/unpublished tags * Remove assessment and text_color fields from Tag * Added validation for published status, added subtree to tag filtering * Revert "Remove assessment and text_color fields from Tag" This reverts commit 28a9bd3. * Fixes * Fix tag subtree filtering & unpublished interaction * convert tag to label * name constraint unique together on assessment * update test output * linting * fix tests from merge * merge migrations * reduce migrations * Labeled Items List (#1091) * label detail page * lint * change to filtered list view * update visual list filter widgets, add permissions * add prefetching, change template tag name, consolidate label html * html formatting * remove get_label_choices * add models to admin & revision * formatting * update form prefix to match new htmx form prefixes * add label to existing view tests * add test_view_htmx for labels * fix check_200 test * update migration order * use helper instead of duplicating code * move code to shared location * code reformatting * move caption to next line * add an icon for consistency with other actions * use lowercase so it'll pass validator * allow uppercase hex too * simplify code * move queryset logic to manager * minor schema updates * simplify and standardize html views; reduce # queries * make plural * make admin read-only * make visible for team members * template formatting * only delete and create those needed * move permission check to each action * catch case where content object does not have get_assessment method * update test and view permission * refactor label htmx urls * rewrite pattern for loading labels to items * lint * make htmx mutation observer reusable * tighten up a few templates * updates * add spinner, fix linking --------- Co-authored-by: casey1173 <caseyhansen1999@gmail.com> Co-authored-by: Andy Shapiro <shapiro.andy@epa.gov> Co-authored-by: Casey Hansen <42587248+caseyhans@users.noreply.github.com> Co-authored-by: Matthew Munns <mmunns16@gmail.com> Co-authored-by: Andy Shapiro <shapiromatron@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.