CPHEAPM-27 Add ToxRefDB to Update Vocab Endpoint #1075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # frontend/animal/EndpointForm/App.js # frontend/animal/EndpointForm/TermSelector.js # frontend/animal/EndpointForm/components/VocabTermFields.js # frontend/animal/EndpointForm/constants.js # frontend/animal/VocabBrowser/App.js # frontend/animal/VocabBrowser/EhvBrowser/Table.js # hawc/apps/animal/forms.py # hawc/apps/assessment/models.py # hawc/apps/vocab/api.py # hawc/apps/vocab/constants.py # hawc/apps/vocab/migrations/0007_load_v2.py # hawc/apps/vocab/migrations/0008_alter_term_namespace.py # hawc/apps/vocab/models.py # hawc/apps/vocab/urls.py # hawc/apps/vocab/views.py # tests/hawc/apps/vocab/test_api.py # tests/hawc/apps/vocab/test_model.py # tests/hawc/apps/vocab/test_views.py
shapiromatron
approved these changes
Sep 10, 2024
There was a problem hiding this comment.
Great job. I made a number of minor edits just rethinking how we do things in general, not specific to your updates. I think use of ToxRefDB data extraction in HAWC is now possible with this PR.
- a9a4a81 format (20 minutes ago)
- 6e0f54d use a lookup (20 minutes ago)
- 066b816 revise lookups (38 minutes ago)
- 363aedb remove debugging (63 minutes ago)
- dba741d text updates (64 minutes ago)
- 262144b add staticmethod props (65 minutes ago)
- 912527e fix api endpoint (65 minutes ago)
- 8ee535c minor edits from code review (2 hours ago)
- 4cae9d9 bump django version minimum (4 hours ago)
|
|
||
| @property | ||
| def display_url(self) -> str: | ||
| return self.display_urls[self.value].lower() | ||
| match self: |
There was a problem hiding this comment.
I switched to a match case instead of two methods for each; I suppose it may not be quite as speedy, but it should be plenty fast either way
|
Hi Andy, Sounds great, I appreciate you taking the time to review and make updates to the ToxRefDB PRs! I'll take a look through the commits and make note of any feedback / updates on how things are handled. Thanks, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
debugfrom TermSelectorupdate_termsAPI to work with EHV or ToxRefDB