Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eco updates from review #1056

Merged
merged 8 commits into from
Jun 28, 2024
Merged

Eco updates from review #1056

merged 8 commits into from
Jun 28, 2024

Conversation

caseyhans
Copy link
Collaborator

  • Update and add new nested terms
  • Replace habitats

@shapiromatron shapiromatron self-requested a review June 24, 2024 14:52
@shapiromatron shapiromatron self-assigned this Jun 24, 2024
shapiromatron
shapiromatron approved these changes Jun 27, 2024
View reviewed changes
Copy link
Owner

@shapiromatron shapiromatron left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - please double check @caseyhans! Here's the notebook I used to process the data and design the migrations: https://github.com/USEPA/cphea-assessments/blob/ajs/projects/hawc/eco/nested-terms-update.ipynb

@caseyhans
Copy link
Collaborator Author

Works for me!

@caseyhans caseyhans merged commit a378bc9 into main Jun 28, 2024
6 checks passed
@caseyhans caseyhans deleted the eco-review-updates branch June 28, 2024 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shapiromatron shapiromatron shapiromatron approved these changes

Assignees

@shapiromatron shapiromatron

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@caseyhans @shapiromatron