Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace <colgroup> and <thead> with bs4 tags #1049

Merged
merged 8 commits into from
Jun 27, 2024
Merged

Replace <colgroup> and <thead> with bs4 tags #1049

merged 8 commits into from
Jun 27, 2024

Conversation

munnsmunns
Copy link
Collaborator

@munnsmunns munnsmunns commented Jun 20, 2024

Replaces use of the <thead> and <colgroup> html tags with the more condensed bs4 template tags where possible. Also replaces alerts with the bs4 alert tag where possible.

Notes:

  • Alerts with additional css classes were left as-is since adding those classes would require changes to the bs4 function. You can find them by searching class="alert in the VSCode search.

@munnsmunns munnsmunns requested a review from shapiromatron June 20, 2024 18:24
@shapiromatron shapiromatron self-assigned this Jun 24, 2024
Copy link
Owner

@shapiromatron shapiromatron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job, I found a few more cleanups but looks good.

@shapiromatron shapiromatron merged commit ddd6d24 into main Jun 27, 2024
6 checks passed
@shapiromatron shapiromatron deleted the bs4-tags branch June 27, 2024 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants