fix identifier DOI dupe checks #1038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shapiromatron
approved these changes
Jun 5, 2024
There was a problem hiding this comment.
LGTM - I made one minor tweak (08c77eb) to keep they types consistent with what they were before.
I think there still may be duplicates that this check doesn't catch, since this only checks HERO IDs which don't already exist in HAWC, and there could be cases where a different HERO ID has the same DOI or something to that effect, so we may need to revisit again in the future, but this is definitely an incremental improvement!
…heck # Conflicts: # .readthedocs.yml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use our DOI regex to check for duplicate DOIs when validating HERO identifiers