Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exploratory heatmap "count column" setting #1034

Merged
merged 7 commits into from
Jun 14, 2024
Merged

Conversation

rabstejnek
Copy link
Collaborator

@rabstejnek rabstejnek commented May 15, 2024

This PR adds a "Count column" setting to exploratory heatmaps where a user can explicitly set the column to get unique counts of.

image
image

The same setting was also integrated into the exploratory heatmap templates.

image
image

@rabstejnek rabstejnek changed the title Added a count column option for exploratory heatmaps Exploratory heatmap "count column" setting May 15, 2024
@rabstejnek rabstejnek marked this pull request as ready for review May 15, 2024 19:57
@rabstejnek rabstejnek requested a review from shapiromatron May 15, 2024 19:57
@shapiromatron shapiromatron self-assigned this Jun 4, 2024
Copy link
Owner

@shapiromatron shapiromatron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job. Made some very minor code edits during the review; please merge if you're happy:

@rabstejnek rabstejnek merged commit 109cde1 into main Jun 14, 2024
6 checks passed
@rabstejnek rabstejnek deleted the heatmap_count_column branch June 14, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants