Assessment Detail/Value adjustments #1028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shapiromatron
requested changes
May 14, 2024
hawc/apps/assessment/templates/assessment/assessmentvalue_detail.html
Outdated
Show resolved
Hide resolved
hawc/apps/assessment/templates/assessment/assessmentvalue_detail.html
Outdated
Show resolved
Hide resolved
hawc/apps/assessment/templates/assessment/assessmentvalue_detail.html
Outdated
Show resolved
Hide resolved
…atron/hawc into assessment-detail-edits
shapiromatron
approved these changes
Jun 5, 2024
| @@ -533,7 +533,7 @@ class AssessmentDetail(models.Model): | |||
| default=constants.PeerReviewType.NONE, | |||
| ) | |||
| qa_id = models.CharField( | |||
| max_length=16, | |||
| max_length=32, | |||
There was a problem hiding this comment.
if you change the model, you have to write a django migration, specifically for changes which alter the SQL schema, as this one would; I went ahead and created one.
hawc/apps/assessment/views.py
Outdated
| @@ -419,6 +420,13 @@ class AssessmentValueDetail(BaseDetail): | |||
| def get_context_data(self, **kwargs): | |||
| context = super().get_context_data(**kwargs) | |||
| context["adaf_footnote"] = constants.ADAF_FOOTNOTE | |||
| # add a message if POD/UF is not equal to the value | |||
| obj = self.object | |||
There was a problem hiding this comment.
I moved this code to the model itself and not the view, since it's more a property of the object itself rather than the view
| {% if obj_perms.edit and value_warning %} | ||
| {% alert warning %} | ||
| The POD/UF = Value is different than what is reported. | ||
| ({{object.pod_value|floatformat:'-3'}}/{{object.uncertainty|floatformat:'-3'}} = {{value_warning|floatformat:'-3'}}, which is different than |
There was a problem hiding this comment.
I didn't know about this one until now, but if you use stringformat instead of floatformat, you can use a lot more options; honestly the floatformat seems pretty limited for our scientific use case https://docs.python.org/3/library/string.html#format-string-syntax
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2 small changes to Assessment details and values: