-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add UDF logs #1023
Add UDF logs #1023
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, though I made a number of edits. I added some new admin views to make it easier to debug, but also wanted to add the user to the logs created so I ended up creating some new middleware to make that possible. Please review and let me know if it works ok and performs as expected; if you're happy we can merge!
LGTM! I fixed one bug I found; in the UDF update view, previewing a schema with required fields would trip up the actual form. The preview schema div is now emptied prior to form submission. If that change looks good to you, then it's ready to merge! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@caseyhans I did a minor update to make it consistent with how we handled this in HERO - we just disable the fieldset so that they're removed from the validation
Adds logging for all UDF functionality, including UserDefinedForm, ModelBinding, TagBinding, ModelUDFContent, and TagUDFContent
A number of larger changers were made to make it to facilitate this task: