-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor HTMX Viewsets #1012
Refactor HTMX Viewsets #1012
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! @shapiromatron back to you
Sorry it took me so long to review your changes @caseyhans, they all looked great, and I really like the generalized templates. This will make things simple, and it's really nice to have such a consistent pattern to use for future work. I made a number of extremely minor changes, please merge if you're happy with the changes:
|
LGTM! |
Refactor our lit.workflows and assessment.attachments HTMX ViewSets to use new
.show-only-child
class and remove nearly-identical templates between eco and epiv2 viewsets. This uses the pattern originally used in #989.show-only-child
hides an element unless it is the only child of a parent elementhide-empty-tbody
will hide an element unless it has a child<tbody>
containing a<tr>
element