turnstile improvements #1004
Merged
turnstile improvements #1004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caseyhans
approved these changes
Mar 12, 2024
There was a problem hiding this comment.
LGTM!
I changed the render response for the Turnstile object to be None instead of an empty string. The empty string was causing the django crispy fields renderer to look for a "" field, which raised a console error since the "" field doesn't exist on the form. 90da45f
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two authentication related changes to hawc, these are only relevant to deployments where users can create an account and they're handled via django directly.
EMAIL_VERIFICATION_REQUIRED, (default False), where a user must validate their email by clicking a link that is sent to their email before they can login. If enabled, a link is emailed when a user attempts to login and their email has not yet been verified. When the link is accessed, the date is logged and then a user can login.In addition fix a bug, where turnstile was misspelled turnstyle. This renames two settings,
TURNSTYLE_SITE -> TURNSTILE_SITEandTURNSTYLE_KEY -> TURNSTILE_KEY.I also reviewed the code coverage and wrote a few additional tests in unrelated code, as well as removed some code that is no longer used.