-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change task table #1000
Merged
Merged
change task table #1000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # hawc/apps/mgmt/templates/mgmt/fragments/task_cell.html # hawc/apps/mgmt/templates/mgmt/fragments/task_form.html
caseyhans
approved these changes
Mar 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I made two minor changes:
- Added colspan=100% for the empty task list cell (09827a1)
- Moved the new task export action to the management dashboard and added dropdown headers to separate assessment analytics from the various task-related actions (55b9993)
- Updated test fixture to match the new task status capitalizations (54aaeca)
PR 1000!! 🎉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the mgmt task table so you can sort/filter by type, status, and due-date. In doing so, we simplified the way these are reported and removed a number of views. "Overdue" tasks are highlighted in yellow. This made a large change where previously each row was a study, and now each row is a task, so there are 4 rows per studies where there was previously one row per study.
Updated the "my assignments" page to simplify dramatically and show much higher level information for each assessment.
Updated the following URLs:
/mgmt/tasks/
- view all tasks and rob reviews assigned to a user/mgmt/assessment/:id/details/
- view all tasks for an assessment.- removed - this is now a link to a filtered version of the task list above (owner == self, status == active)/mgmt/:id/tasks/
Fixed a bug where epiv2 design extractions didn't trigger start of data extracion too.