Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change task table #1000

Merged
merged 11 commits into from
Mar 13, 2024
Merged

change task table #1000

merged 11 commits into from
Mar 13, 2024

Conversation

shapiromatron
Copy link
Owner

@shapiromatron shapiromatron commented Feb 25, 2024

Update the mgmt task table so you can sort/filter by type, status, and due-date. In doing so, we simplified the way these are reported and removed a number of views. "Overdue" tasks are highlighted in yellow. This made a large change where previously each row was a study, and now each row is a task, so there are 4 rows per studies where there was previously one row per study.

image

Updated the "my assignments" page to simplify dramatically and show much higher level information for each assessment.

image

Updated the following URLs:

  • /mgmt/tasks/ - view all tasks and rob reviews assigned to a user
  • /mgmt/assessment/:id/details/ - view all tasks for an assessment.
  • /mgmt/:id/tasks/ - removed - this is now a link to a filtered version of the task list above (owner == self, status == active)

Fixed a bug where epiv2 design extractions didn't trigger start of data extracion too.

# Conflicts:
#	hawc/apps/mgmt/templates/mgmt/fragments/task_cell.html
#	hawc/apps/mgmt/templates/mgmt/fragments/task_form.html
@shapiromatron shapiromatron requested a review from caseyhans March 5, 2024 22:23
@shapiromatron shapiromatron marked this pull request as ready for review March 5, 2024 22:23
Copy link
Collaborator

@caseyhans caseyhans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I made two minor changes:

  • Added colspan=100% for the empty task list cell (09827a1)
  • Moved the new task export action to the management dashboard and added dropdown headers to separate assessment analytics from the various task-related actions (55b9993)
  • Updated test fixture to match the new task status capitalizations (54aaeca)

PR 1000!! 🎉

@shapiromatron shapiromatron merged commit 228c2f8 into main Mar 13, 2024
6 checks passed
@shapiromatron shapiromatron deleted the task-table branch March 13, 2024 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants