Skip to content

Commit

Permalink
fix another regression from #732
Browse files Browse the repository at this point in the history
  • Loading branch information
shapiromatron committed Apr 6, 2023
1 parent 257e9fc commit cdda8bc
Show file tree
Hide file tree
Showing 3 changed files with 15 additions and 8 deletions.
8 changes: 4 additions & 4 deletions hawc/apps/mgmt/api.py
Original file line number Diff line number Diff line change
Expand Up @@ -26,18 +26,18 @@ def get_queryset(self):
@action(detail=False, permission_classes=(permissions.IsAuthenticated,))
def assignments(self, request):
# Tasks assigned to user.
qs = self.model.objects.owned_by(request.user).select_related(
qs = self.model.objects.select_related(
"owner", "study", "study__reference_ptr", "study__assessment"
)
).owned_by(request.user)
serializer = serializers.TaskByAssessmentSerializer(qs, many=True)
return Response(serializer.data)

@action(detail=False, action_perms=AssessmentViewSetPermissions.CAN_VIEW_OBJECT)
def assessment_assignments(self, request):
# Tasks assigned to user for a specific assessment
qs = (
self.model.objects.owned_by(request.user)
.filter(study__assessment=self.assessment)
self.model.objects.filter(study__assessment=self.assessment)
.owned_by(request.user)
.select_related("owner", "study", "study__reference_ptr", "study__assessment")
)
serializer = serializers.TaskByAssessmentSerializer(qs, many=True)
Expand Down
11 changes: 9 additions & 2 deletions hawc/apps/mgmt/managers.py
Original file line number Diff line number Diff line change
@@ -1,17 +1,24 @@
import logging

from django.db.models import QuerySet

from ..common.models import BaseManager
from ..study.models import Study
from . import constants

logger = logging.getLogger(__name__)


class TaskQuerySet(QuerySet):
def owned_by(self, user):
return self.filter(owner=user)


class TaskManager(BaseManager):
assessment_relation = "study__assessment"

def owned_by(self, user):
return self.filter(owner=user)
def get_queryset(self):
return TaskQuerySet(self.model, using=self._db)

def create_assessment_tasks(self, assessment):
"""
Expand Down
4 changes: 2 additions & 2 deletions hawc/apps/mgmt/views.py
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ class UserAssignments(RobTaskMixin, WebappMixin, LoginRequiredMixin, ListView):
template_name = "mgmt/user_assignments.html"

def get_queryset(self):
return self.model.objects.owned_by(self.request.user)
return self.model.objects.all().owned_by(self.request.user)

def get_rob_queryset(self, RiskOfBias):
return RiskOfBias.objects.filter(author=self.request.user, active=True)
Expand All @@ -112,8 +112,8 @@ def get_queryset(self):
return (
super()
.get_queryset()
.owned_by(self.request.user)
.filter(study__assessment=self.assessment)
.owned_by(self.request.user)
.select_related("owner", "study", "study__reference_ptr", "study__assessment")
)

Expand Down

0 comments on commit cdda8bc

Please sign in to comment.