Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync Commands display language #886

Closed
SSvilen opened this issue May 14, 2019 · 4 comments
Closed

Sync Commands display language #886

SSvilen opened this issue May 14, 2019 · 4 comments

Comments

@SSvilen
Copy link

SSvilen commented May 14, 2019

🐛 Describe the bug
I have a Windows OS in German. My VS Code is configured in English .
When I go to Command Palette (Ctrl+Shift+P) and then I type SYNC: I see the sync commands in English (for instance Sync: How to configure, etc.. ). When I go to 'Sync: Advanced Options' all the commands in the sub-menu are in German. (or most of them).

🌴 Visual Studio Code Version :
Version: 1.33.1 (system setup)
Commit: 51b0b28134d51361cf996d2f0a1c698247aeabd8
Date: 2019-04-11T08:27:14.102Z
Electron: 3.1.6
Chrome: 66.0.3359.181
Node.js: 10.2.0
V8: 6.6.346.32

🌴 Code Settings Sync Version : 3.2.9
🌴 Standard or Insiders : Standard
🌴 Portable or Installed : Intalled
🌴 OSS or Official Build : Official Build
🌴 Operating System : Windows_NT x64 10.0.16299
🌴 Occurs On: [Using ]
🌴 Proxy Enabled: [ Yes]

📰 To Reproduce
Steps to reproduce the behavior:

  1. Go to Command Palette (Ctrl+Shift+P)
  2. type 'Sync: Advanced Options'
  3. Enter to choose the menu
  4. The sub-menu is in German
    image

💪 Expected behavior
I guess it needs to take the language of VS Code.

@shanalikhan
Copy link
Owner

I see the sync commands in English (for instance Sync: How to configure, etc.. ). When I go to 'Sync: Advanced Options' all the commands in the sub-menu are in German. (or most of them).

@arnohovhannisyan can we fix this ? We need to read local of vscode instead of windows i suppose.

@auxves
Copy link
Contributor

auxves commented Jun 19, 2019

@shanalikhan VSCode creates a file called locale.json in the User folder that has the exact same contents as the localize.ts config. I guess we can just read that file and parse that instead of the environmental variable.

@auxves auxves mentioned this issue Jun 19, 2019
1 task
@auxves
Copy link
Contributor

auxves commented Jun 19, 2019

@shanalikhan shanalikhan added this to the v3.3.0 milestone Jun 19, 2019
shanalikhan pushed a commit that referenced this issue Jun 19, 2019
* Resolve locale properly

* Clean constructor

* Use state instead of passing in argument
shanalikhan pushed a commit that referenced this issue Jun 24, 2019
* Resolve locale properly

* Clean constructor

* Use state instead of passing in argument
@shanalikhan
Copy link
Owner

I have released new version of Settings Sync v3.3.0 fixing this issue. Im closing this ticket let me know if u guys run into some problem

shanalikhan pushed a commit that referenced this issue Jul 1, 2019
* Updated to task api 2.0.0 and fixed tests

* Set "extensionKind": "ui" to support remote development #61

Fixes #870. See that issue for details

* Clean up previous commits into one

* #800 #515 #854

* Utilized pragmaUtil Functions for kb.json file

* Typo fix

* Added universalKeybindings setting

* chore(package): update @types/node to version 12.0.0 (#873)

* Cleaned up toggling commented settings (#877)

* Cleaned up toggling commented settings

* Updated to include fix by @ioprotium

* Fix warning with webpack

* Update UI

* Change height to max-height

* Add image locally and move it to the top

* Added documentation for tests in CONTRIBUTING.md (#881)

* fix(package): update fs-extra to version 8.0.0 (#882)

* chore(package): update @types/fs-extra to version 7.0.0 (#885)

* chore(package): update @types/node to version 12.0.1 (#883)

* fix(package): update fs-extra to version 8.0.1 (#884)

* Update UI to fit guidelines

* chore(package): update @types/node to version 12.0.2 (#887)

* Improve UI and functionality

* Match BG of theme and properly contrast text

* Fix issues with themes

* Fix image not showing up with light theme

* Fix issues with contrast

* Fix issue with VS Code's WebView

* Update UI and functionality

* Fix potential issue with light themes

* Fix issues with theme on modal

* Refactor

* Add new (but experimental) localizations (#898)

* chore(package): update clean-webpack-plugin to version 3.0.0 (#899)

*  #891

* Update settings page after a reset

* Improve code

* fix(clean-webpack-plugin): (#901)

clean-webpack-plugin was recently updated, and it had breaking changes.

* chore(package): update @types/node to version 12.0.3 (#897)

* #668

* fix(OSS):

enums.ts
----
Allow for setting os type with less code

environmentPath.ts
----
Find code folder and extensions folder more efficiently
Get OS type more efficiently

settings.ts
----
Ignore all state files

sync.ts
----
Adapt for changes in pluginService

pluginService.ts
----
Use vscode command to install extensions
Clean up code and simplify names

* Install extensions in order

* Comment legacy code instead of deleting it

* Fix extension install

* Fix issue with extensions always being deleted

* Get code path more efficiently

* Make sure to escape spaces in cli path

* Fix issues with portable builds

* Support Windows and certain editions

* Improve method for finding extension folder

* Start using API for installation

* Prepare for new API command

* Get ready for new API command

* Fix issue with installation

* Commit requested changes

* #668

* Format pluginService.ts (#906)

* #668

* Throw error

* Try to fix issues with getting missing

* chore(package): update @types/node to version 12.0.7 (#904)

* chore(package): update @types/node to version 12.0.8 (#908)

* #668

* #668

* #668

* #839

* Support multiple instances

* Completely switch to state

* Update to work properly

* Move setting classes to their own models

* Update service names

* Only auto upload using focused window

* Resolve merge conflicts

* #886

* Resolve locale properly

* Clean constructor

* Use state instead of passing in argument

* Update to be compatible with v3.3.0 changes

* Fix readme

* Fix package.json

* Add new settings

* Increase contrast

* Update

package.nls.*.json
----
Add localizations for setting names and placeholders.

github.oauth.service.ts
----
Handle errors in a more user-facing way
Support GitHub enterprise
Show message to user after success

webview.service.ts
----
Use new localizations for names and placeholders

* Bug fix and upload images

* Add support for commits to master (release notes)

* Fix issue

* Fix another issue with release notes

* Update release note template

* Update release notes

* Don't open gist selection if there aren't any gists

* Allow user to view gist

* Revert accidental change

* Support public gist

* Add css, js, and fonts to repo

* Improve font injection

* Revert accidental change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants