Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add file and blob globals to eslint config #1

Closed
wants to merge 1 commit into from

Conversation

shamilovtim
Copy link
Owner

@shamilovtim shamilovtim commented Apr 2, 2021

Summary

The eslint community config does not have the File and Blob polyfills in globals which have been part of the Javascript implementation for ~3 years. They were added to the Javascript API in facebook#11573 by @satya164.

Changelog

[General] [Fixed] - Added File and Blob globals to eslint community config

Test Plan

Evidence these globals exist:

  1. Implement Blob support for XMLHttpRequest facebook/react-native#11573
  2. Executed the following:

Screen Shot 2021-04-02 at 12 08 50 PM

Screen Shot 2021-04-02 at 12 11 56 PM

  1. Receive in console:

Screen Shot 2021-04-02 at 12 09 59 PM

Screen Shot 2021-04-02 at 12 12 27 PM

Evidence the PR works: the globals in the PR identical to the others in the eslint community config that they are in

@shamilovtim shamilovtim closed this Apr 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant