-
-
Notifications
You must be signed in to change notification settings - Fork 631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Typo in rescue for server rendering #963
Conversation
@railsme this is GREAT! Can you please add a CHANGELOG.md entry and I'll merge this. Reviewed 1 of 1 files at r1. Comments from Reviewable |
done 👌 Comments from Reviewable |
Reviewed 1 of 1 files at r2. CHANGELOG.md, line 11 at r2 (raw file):
We can make this description a bit more detailed, along the lines of the rubocop comment broke...and this fixed ... plus, please rebase your change on master I can't merge right now due to a conflict... Comments from Reviewable |
Should be better now 😃 |
@railsme We're not passing Travis |
@justin808 #899 broke the build. Should I try to fix it in my PR or wait for fix from the author? 🤔 |
If you can fix it, I’d be thrilled. In this pr is fine. |
@justin808, I've found that we are using empty strings as default values for not set config options. |
@justin808 |
Reviewed 1 of 1 files at r3. Comments from Reviewable |
This change is