Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return empty json when nil in json_safe_and_pretty #824

Merged
merged 1 commit into from
Apr 28, 2017
Merged

Return empty json when nil in json_safe_and_pretty #824

merged 1 commit into from
Apr 28, 2017

Conversation

dzirtusss
Copy link
Contributor

@dzirtusss dzirtusss commented Apr 27, 2017 •
edited by justin808
Loading

This change is Reviewable

@dzirtusss dzirtusss force-pushed the sergey/fix-nil-json branch from 2cbb514 to 4fb52e5 Compare April 27, 2017 17:07
@coveralls
Copy link

coveralls commented Apr 27, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 98.022% when pulling 4fb52e5 on sergey/fix-nil-json into 2dcafd3 on master.

@coveralls
Copy link

coveralls commented Apr 27, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 98.022% when pulling 4fb52e5 on sergey/fix-nil-json into 2dcafd3 on master.

@justin808
Copy link
Member

:lgtm:

Reviewed 3 of 3 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks broke.

Comments from Reviewable

@justin808 justin808 merged commit d2ca910 into master Apr 28, 2017
@justin808 justin808 deleted the sergey/fix-nil-json branch June 4, 2017 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dzirtusss @coveralls @justin808