Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Documentation About Deploying to Elastic Beanstalk with Yarn #790

Merged

Conversation

chrisjones-tripletri
Copy link
Contributor

@chrisjones-tripletri chrisjones-tripletri commented Apr 2, 2017

When the yarn dependency was introduced, it made asset precompilation on elastic beanstalk fail, since elastic beanstalk does not have yarn installed by default. Added a sample .ebextensions file which installs yarn and resolves the dependency issue.


This change is Reviewable

@coveralls
Copy link

coveralls commented Apr 2, 2017

Coverage Status

Coverage remained the same at 97.919% when pulling 870303c on chrisjones-tripletri:elastic-beanstalk-yarn-docs into 7f04afd on shakacode:master.

@justin808
Copy link
Member

tiny formatting suggestion

LOOKS GREAT! Thanks!


Reviewed 2 of 2 files at r1.
Review status: all files reviewed at latest revision, 2 unresolved discussions.


docs/additional-reading/elastic-beanstalk.md, line 3 at r1 (raw file):

# Deploying React on Rails to Elastic Beanstalk

In order to deploy a React on Rails app to elastic beanstalk, you must install yarn on each instance.  

trailing whitespace.


docs/additional-reading/elastic-beanstalk.md, line 26 at r1 (raw file):

    command: 'sudo wget https://dl.yarnpkg.com/rpm/yarn.repo -O /etc/yum.repos.d/yarn.repo'

let's use one blank line between sections


Comments from Reviewable

@coveralls
Copy link

coveralls commented Apr 3, 2017

Coverage Status

Coverage remained the same at 97.919% when pulling 94c0227 on chrisjones-tripletri:elastic-beanstalk-yarn-docs into 7f04afd on shakacode:master.

@justin808 justin808 merged commit 3269da9 into shakacode:master Apr 3, 2017
@justin808
Copy link
Member

Thanks @chrisjones-tripletri!

@josephecombs
Copy link
Contributor

Awesome PR, thanks for adding this! I will mention that I had to do the things mentioned here to get this solution to work AFTER adding the .ebextension mentioned in this PR:

http://tech.nickserra.com/2016/11/15/npm-install-error-eacces-permission-denied-mkdir-homewebapp/

@justin808
Copy link
Member

@josephecombs Any chance that you can summarize what you need in a PR to the doc that @chrisjones-tripletri added?

@josephecombs
Copy link
Contributor

yes, doing this now

@kkak10
Copy link

kkak10 commented Feb 19, 2018

why make folder /home/webapp ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants