Improve i18n Integration #748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@JasonYCHuang Please review! |
* Better error message if the value of the i18n directory is invalid. * Added test for configuration error message. * DRY'd up code for checking if this config value is set. * Improved comments in sample react_on_rails.rb config file
3d379b0 to
c6e6911
Compare
|
@robwise any quick review? |
|
@JasonYCHuang and @robwise Please review! |
|
I created a test project to test this, and it works good. Maybe we can add red color to error message in the future. Review status: 0 of 8 files reviewed at latest revision, all discussions resolved, some commit checks failed. Comments from Reviewable |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is