Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/no request context #509

Merged
merged 1 commit into from
Aug 8, 2016

Conversation

eacaps
Copy link
Contributor

@eacaps eacaps commented Aug 3, 2016

Added support for server rendering in ActionMailer contexts. Work was primarily done for #486 and this pull request was resubmitted to squash the commits.


This change is Reviewable

@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 82.338% when pulling c1f5295 on eacaps:feature/no-request-context into 63436ab on shakacode:master.

@justin808
Copy link
Member

2 minor issues:

  1. Typo in the changelog.
  2. the commit message could be just a few line, such as what is in the changelog entry.

Thanks again @eacaps! Great job!


Reviewed 6 of 6 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion.


CHANGELOG.md, line 8 [r1] (raw file):

## [Unreleased]

- React on Rails server rendering can now be used in contextes without request, mostly useful for usage in ActionMailer templates [#486](https://github.com/shakacode/react_on_rails/pull/486)

Typo contextes

React on Rails server rendering now supports contexts outside of browser rendering, such as ActionMailer templates [#486](https://github.com/shakacode/react_on_rails/pull/486)

I also like to put in author attribution! See a bit further below.

(ps., feel free to fill in in the others directly missing below)


Comments from Reviewable

@justin808
Copy link
Member

@eacaps I look forward to your update. If you can't get to it, please let me know.

…ser rendering, such as ActionMailer templates
@eacaps eacaps force-pushed the feature/no-request-context branch from c1f5295 to 60afe39 Compare August 5, 2016 15:36
@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 82.338% when pulling 60afe39 on eacaps:feature/no-request-context into c77d3b6 on shakacode:master.

@justin808
Copy link
Member

:lgtm:


Reviewed 1 of 1 files at r2.
Review status: all files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.


Comments from Reviewable

@justin808 justin808 merged commit c1a67f0 into shakacode:master Aug 8, 2016
@justin808
Copy link
Member

Big thanks @eacaps!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants