Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

have rails start on port 3000 (foreman uses 5000 by default) #456

Closed
wants to merge 1 commit into from
Closed

have rails start on port 3000 (foreman uses 5000 by default) #456

wants to merge 1 commit into from

Conversation

joyvuu-dave
Copy link

@joyvuu-dave joyvuu-dave commented Jun 19, 2016 •
edited by justin808
Loading

This addresses #402.

This change is Reviewable

@coveralls
Copy link

Coverage Status

Coverage remained the same at 82.305% when pulling 208841c on joyvuu-dave:master into fb220ee on shakacode:master.

@justin808
Copy link
Member

@jbhatab Can you please review. This concerned the generator changes.

@jbhatab
Copy link
Member

jbhatab commented Jul 7, 2016

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

@jbhatab
Copy link
Member

jbhatab commented Jul 7, 2016

LGTM

Comments from Reviewable

@jbhatab jbhatab mentioned this pull request Jul 7, 2016
Merged
@justin808
Copy link
Member

See #467. Merged.

@justin808 justin808 closed this Jul 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jbhatab jbhatab

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@joyvuu-dave @coveralls @justin808 @jbhatab