Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prevent concatenation of rake lint params to npm lint params #299

Merged
merged 1 commit into from
Feb 27, 2016
Merged

prevent concatenation of rake lint params to npm lint params #299

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/generators/react_on_rails/templates/base/base/client/server.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ server.app.use('/', (req, res) => {
server.listen(PORT, 'localhost', err => {
if (err) console.error(err);
console.log(
'=> 🔥 Webpack development server is running on port ' + PORT
`=> 🔥 Webpack development server is running on port ${PORT}`
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now this is spotted by linters

);
});
compiler.plugin('done', () => {
Expand Down
4 changes: 2 additions & 2 deletions lib/generators/react_on_rails/templates/base/base/lib/tasks/linters.rake.tt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,14 +57,14 @@ if %w(development test).include? Rails.env
<%- unless options.skip_js_linters? -%>
desc "eslint"
task :eslint do
cmd = "cd client && npm run eslint . -- --ext .jsx,.js"
cmd = "cd client && npm run eslint"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these params are already in client/package.json

puts "Running eslint via `#{cmd}`"
sh cmd
end

desc "jscs"
task :jscs do
cmd = "cd client && npm run jscs ."
cmd = "cd client && npm run jscs"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prevents double pass

puts "Running jscs via `#{cmd}`"
sh cmd
end
Expand Down