Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Foreman as a dependency. #248

Merged
merged 1 commit into from
Feb 1, 2016
Merged

Added Foreman as a dependency. #248

merged 1 commit into from
Feb 1, 2016

Conversation

jamespearson
Copy link
Contributor

Review on Reviewable

@justin808
Copy link
Member

@fearmediocrity Most devs have foreman installed globally. Any reason we should add to the gemspec? for contributors?

I could see maybe adding this to what's generated. Maybe it's already there.

@jamespearson
Copy link
Contributor Author

I added it because if you follow your instructions I had to manually. ( I was using a sandboxed app to try it out).

If a dev already uses it then it will be an already satisfied dependency, if not it will save a minute of head scratching for the beginner coming from React to Rails.

justin808 added a commit that referenced this pull request Feb 1, 2016
Added Foreman as a dependency.
@justin808 justin808 merged commit 449099b into shakacode:master Feb 1, 2016
@justin808
Copy link
Member

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants