-
-
Notifications
You must be signed in to change notification settings - Fork 631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update tsconfig.json
to extend a standard one
#1700
base: master
Are you sure you want to change the base?
Conversation
WalkthroughThis update introduces configuration clarifications and dependency enhancements. In Changes
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (3)
🚧 Files skipped from review as they are similar to previous changes (3)
⏰ Context from checks skipped due to timeout of 90000ms (2)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
d5a2a71
to
7499919
Compare
tsconfig.json
to extend the Node 16 tsconfigtsconfig.json
to extend the Node 14 tsconfig
80c51c7
to
21c5744
Compare
tsconfig.json
to extend the Node 14 tsconfigtsconfig.json
to extend a standard one
21c5744
to
e78c5db
Compare
e78c5db
to
7b4beb7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your changes no longer match the PR description.
@Judahmeek #1697 currently has |
7b4beb7
to
0dbb3de
Compare
Summary
Extracted
tsconfig.json
changes equivalent from #1697 (exceptlib
is set to["es2020"]
without"dom"
, but we don't use any DOM APIs).Effectively:
module
andmoduleResolution
tonode16
(strictly superior tocommonjs
);lib
andtarget
toes2020
.Pull Request checklist
[ ] Add/update test to cover these changes[ ] Update documentationThis change is
Summary by CodeRabbit
Summary by CodeRabbit