Generate Pack if Missing Generated Pack for Registered Component #1506
Conversation
18f8aa8 to
ea9864a
Compare
This is a feature that Get's Triggered Only If someone creates a new component while Rails Server is still running. I don't know if we have test cases to cover such scenarios or if we should plan to add them. |
lib/react_on_rails/helper.rb
Outdated
| @@ -556,8 +556,7 @@ def initialize_redux_stores | |||
|
|
|||
| def raise_generated_missing_pack_warning(component_name) | |||
| msg = <<~MSG | |||
| **ERROR** ReactOnRails: Generated missing pack for Component: #{component_name}. Please refresh the webpage \ | |||
| once webpack has finished generating the bundles. If the problem persists | |||
| **ERROR** ReactOnRails: Generated missing pack for Component: #{component_name}. Please restart the webpack dev server to ensure webpack generates the chunks corresponding to #{component_name} component. If the problem persists | |||
There was a problem hiding this comment.
We can not run webpack in watch mode as creating a new Component makes a new entry point. To accommodate this new entry point, the server needs to get restarted as setEntry to webpack is configured on initialization of webpack.
There was a problem hiding this comment.
that's my point
the error says webpack dev server only
|
|
||
| is_generated_directory_present = Dir.exist?(generated_packs_directory_path) | ||
|
|
||
| return if is_generated_directory_present && webpack_assets_status_checker.stale_generated_component_packs.empty? | ||
| return if is_generated_directory_present && stale_or_missing_packs.empty? |
There was a problem hiding this comment.
is the stale_or_missing_packs list used to optimize what's generated?
There was a problem hiding this comment.
If not, then why keep going after one is detected?
There was a problem hiding this comment.
This optimization should be a separate PR as it requires additional testing and might introduce new bugs if not done correctly. Considering the time sensitivity of this work, I would suggest creating a new Issue for optimization, which we can work on later.
There was a problem hiding this comment.
then exit early on the first found stale or missing entry
There was a problem hiding this comment.
We will use this list later to generate packs just for them. I can exit it early by making the stale_or_missing_packs return boolean. But since we are going to use it very soon, I suggest keeping it this way for now.
ddf4b6b to
4f0361d
Compare
f145bb4 to
a48c46d
Compare
a48c46d to
6ae3f54
Compare
| msg = <<~MSG | ||
| **ERROR** ReactOnRails: Generated missing pack for Component: #{component_name}. Please refresh the webpage \ | ||
| once webpack has finished generating the bundles. If the problem persists | ||
| **ERROR** ReactOnRails: Generated missing pack for Component: #{component_name}. Please restart the webpack dev server or webpack in watch mode, to ensure webpack generates the chunks corresponding to #{component_name} component. If the problem persists |
There was a problem hiding this comment.
should this error message be detected in some tests?
Problem
Currently, The Generate Pack Script handles the on-demand generation of packs only for existing components by checking m_time to verify if the generated packs are stale. If a user creates a new Component under
components_subdirectory,It's not tracked bystale_generated_component_packs;Solution and Changes in PR
This PR updates the FS-based Pack generation feature by adding a check for missing_packs. The system will generate a new pack when either the components are stale, or a new component is created.
This change is