-
-
Notifications
You must be signed in to change notification settings - Fork 631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for React 18 server rendering #1409
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
099aefb
add support diff versions of React's render API
kylemellander 97d6d6f
update logic to see if hydrate is supported
kylemellander b19d798
move files to reusables so that they can work for ReactOnRails
kylemellander 292a85c
use ReactDOM.version to determine API for rendering and hydrating
kylemellander File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
import ReactDOM from 'react-dom'; | ||
import { ReactElement, Component } from 'react'; | ||
import supportsReactCreateRoot from './supportsReactCreateRoot'; | ||
|
||
export default function reactHydrate(domNode: Element, reactElement: ReactElement): void | Element | Component { | ||
if (supportsReactCreateRoot) { | ||
// @ts-expect-error potentially present if React 18 or greater | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please check if the |
||
return ReactDOM.hydrateRoot(domNode, reactElement); | ||
} | ||
|
||
return ReactDOM.hydrate(reactElement, domNode); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
import ReactDOM from 'react-dom'; | ||
import { ReactElement, Component } from 'react'; | ||
import supportsReactCreateRoot from './supportsReactCreateRoot'; | ||
|
||
export default function reactRender(domNode: Element, reactElement: ReactElement): void | Element | Component { | ||
if (supportsReactCreateRoot) { | ||
// @ts-expect-error potentially present if React 18 or greater | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please check if the |
||
const root = ReactDOM.createRoot(domNode); | ||
root.render(reactElement); | ||
return root | ||
} | ||
|
||
// eslint-disable-next-line react/no-render-return-value | ||
return ReactDOM.render(reactElement, domNode); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
import ReactDOM from 'react-dom'; | ||
|
||
const reactMajorVersion = parseInt(ReactDOM.version.split('.')[0], 10); | ||
export default reactMajorVersion >= 18; |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check if the
@ts-expect-error
messages are still needed.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately, these are still needed. We could upgrade the types library to the react beta to get around having to do this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pros and cons of doing that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the pros are:
The cons are a couple:
My recommendation would be to ignore it for now until it gets out of beta and then upgrade the types.