React on Rails ReasonHelloWorld component #1215
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- bsconfig
- bsb make and clean commands in build
- ReasonHelloWorld.re component
- added component to client registration file
RAILS
- add route
- add hyperlink on main page
- view file
- added bs-react-on-rails -
ljuster
commented
May 9, 2019
| @@ -4,6 +4,7 @@ import 'es5-shim'; | |||
| import ReactOnRails from 'react-on-rails'; | |||
|
|
|||
| import HelloWorld from '../components/HelloWorld'; | |||
| import HelloWorldReason from '../components/HelloWorldReason.bs'; | |||
There was a problem hiding this comment.
@justin808 as is, it won't recognize HelloWorldReason.bs component.
clientRegistration.jsx?209f:1 Uncaught Error: Cannot find module "../components/HelloWorldReason.bs"
There was a problem hiding this comment.
This is just not how you integrate the bs into the JS. The JS code needs the compiled file to import.
|
@ljuster how's this going? We need CI to pass. |
|
@Judahmeek check this one out. Would be great to get this merged. |
|
@Judahmeek @behraaangm can we get this merged into spec/dummy? |
|
Hey @justin808, I wanna make a new branch from this work. |
Sure!
Yes! |
|
See #1399 |
gscarv13
added a commit
to gscarv13/react_on_rails
that referenced
this pull request
Nov 3, 2021
Merged
justin808
pushed a commit
that referenced
this pull request
Dec 30, 2021
* Cherry-pick commits from #1215 * Add ReScript dependencies and configuration * Remove Reason file, Replace Reason occurrences by ReScript * Add ReScript component, update yarn.lock at spec/dummy/ Create file to import compiled ReScript components * Add rake task to build ReScript when running rake assets:precompile * Add JavaScript dependency required to build for production * Run prettier and add *.bs.js files to .prettierignore * Add return at the end of the line package.json * Bump prettier, concurrently and prettier-eslint-cli add files to .prettierignore * Update bsconfig.json
superdev9082
added a commit
to superdev9082/react_on_rails
that referenced
this pull request
Feb 16, 2023
* Cherry-pick commits from shakacode/react_on_rails#1215 * Add ReScript dependencies and configuration * Remove Reason file, Replace Reason occurrences by ReScript * Add ReScript component, update yarn.lock at spec/dummy/ Create file to import compiled ReScript components * Add rake task to build ReScript when running rake assets:precompile * Add JavaScript dependency required to build for production * Run prettier and add *.bs.js files to .prettierignore * Add return at the end of the line package.json * Bump prettier, concurrently and prettier-eslint-cli add files to .prettierignore * Update bsconfig.json
Web-Go-To
added a commit
to Web-Go-To/react-with-rails
that referenced
this pull request
Mar 19, 2023
* Cherry-pick commits from shakacode/react_on_rails#1215 * Add ReScript dependencies and configuration * Remove Reason file, Replace Reason occurrences by ReScript * Add ReScript component, update yarn.lock at spec/dummy/ Create file to import compiled ReScript components * Add rake task to build ReScript when running rake assets:precompile * Add JavaScript dependency required to build for production * Run prettier and add *.bs.js files to .prettierignore * Add return at the end of the line package.json * Bump prettier, concurrently and prettier-eslint-cli add files to .prettierignore * Update bsconfig.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
REASON/REACT
- bsconfig
- bsb make and clean commands in build
- ReasonHelloWorld.re component
- added component to client registration file
RAILS
- add route
- add hyperlink on main page
- view file
This change is